[Commits] commit/EinsteinInitialData: koppel: TwoPunctures: fix segfault and miscalc when using single precision

Bitbucket commits-noreply at bitbucket.org
Thu May 26 12:40:15 CDT 2016

1 new commit in EinsteinInitialData:

Changeset:   d727a41c8fc6
Branch:      master
User:        koppel
Date:        2016-05-26 17:34:16+00:00
Summary:     TwoPunctures: fix segfault and miscalc when using single precision

When using EinsteinInitialData/TwoPunctures with CCTK_REAL set to
single-precision memory-access errors and incorrect results were
encountered. The incorrect results could potentially affect
double-precision code too.

The memory access errors occur due to double* / CCTK_REAL* confusion.

The incorrect results are due to rounding errors in
PunctTaylorExpandAtArbitPosition that push an acos argument outside of
[-1,1]. Though this was encountered with single-precision code, perhaps
it could occur with DP code too.

This fixes ticket 1894.

Affected #:  1 file

Repository URL: https://bitbucket.org/einsteintoolkit/einsteininitialdata/


This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

More information about the Commits mailing list