[Commits] commit/WVUThorns: 38 new changesets

Bitbucket commits-noreply at bitbucket.org
Thu Aug 30 20:59:18 CDT 2018


38 new commits in WVUThorns:

https://bitbucket.org/zach_etienne/wvuthorns/commits/84b6dc8ddfdb/
Changeset:   84b6dc8ddfdb
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE/GiRaFFEfood: Add code tests, with tolerances set based on GCC vs ICC compiler results

Affected #:  32 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/85e4f251eaef/
Changeset:   85e4f251eaef
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE: Revise tolerances based on third machine/compiler -- only GiRaFFE_tests_FastWave affected.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/7ace6f28022b/
Changeset:   7ace6f28022b
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE: Update GiRaFFE tests, this time using boundary conditions consistent with what might be used in production.

Affected #:  32 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/6afe3e82cc5e/
Changeset:   6afe3e82cc5e
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE: Adjust floor value on tolerance tests to 1e-12. Should fix Jenkins failure.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/68acfd9875cd/
Changeset:   68acfd9875cd
Branch:      None
User:        rhaas80
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE: remove explicit BLAS and LAPACK from tests

instead let them be auto-activated. Not requesting a specific thorn lets
this work eg with OpenBLAS which provides the LAPACK and BLAS capability
but is not called BLAS or LAPACK.

Affected #:  18 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/8c087b4bdf07/
Changeset:   8c087b4bdf07
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE: impose_speed_limit_output_u0(): Declare a CCTK_REAL as const and remove comments from earlier version of the code.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/0c36e880a996/
Changeset:   0c36e880a996
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE: Update documentation, at reviewer Roland Haas' request.
GiRaFFE/IllinoisGRMHD: Remove SCRIPT and LANG from configuration.ccl

Affected #:  3 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/a7b67870fa15/
Changeset:   a7b67870fa15
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Add warning that current symmetry thorns in ETK do not support staggered gridfunctions

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/57e2a17ea079/
Changeset:   57e2a17ea079
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Document that the "st" in mhd_st_i = \tilde{S}_i stands for "\tilde{S}"

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/cb2e2b8d06c8/
Changeset:   cb2e2b8d06c8
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: remove commented-out, wrong prolongation operators

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/b0848b2465f2/
Changeset:   b0848b2465f2
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Remove backslashes from interface.ccl comment blocks, so as not to confuse the parser.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/62b0edd3a6d1/
Changeset:   62b0edd3a6d1
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Make sure all gridfunction groups are properly commented, both in GiRaFFE and IllinoisGRMHD.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/d420c76fb902/
Changeset:   d420c76fb902
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Remove GiRaFFE_MaxNumEvolvedVars and IllinoisGRMHD_MaxNumEvolvedVars from GiRaFFE and IllinoisGRMHD, respectively. MoL now figures this out on its own.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/00231eba9fe1/
Changeset:   00231eba9fe1
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Remove "equatorial" symmetry option from GiRaFFE and IllinoisGRMHD until it has been fully tested.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/b5056987f6da/
Changeset:   b5056987f6da
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Add nice gridfunction staggering table to documentation

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/8e978122ca40/
Changeset:   8e978122ca40
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Move all Aligned Rotator test parameters from the GiRaFFE evolution thorn to GiRaFFEfood, and add a new parameter "min_radius_inside_of_which_conserv_to_prims_FFE_and_FFE_evolution_is_DISABLED" that does exactly what its name suggests. Update the Aligned rotator test result.

Affected #:  8 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/dca0d3d19fd6/
Changeset:   dca0d3d19fd6
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Give rule of thumb for setting damp_lorenz; remove extraneous comments

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/192c73ae347d/
Changeset:   192c73ae347d
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Clean up test suite parameter files and output

Affected #:  31 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/05b47a4bd0e1/
Changeset:   05b47a4bd0e1
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE/IllinoisGRMHD: Update damp_lorenz comment in param.ccl to be more useful.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/d07e3e771a28/
Changeset:   d07e3e771a28
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Update schedule.ccl according to reviewer's comments.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/841272212d39/
Changeset:   841272212d39
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE tests: Update Exact Wald result after scheduling fix

Affected #:  3 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/8106aee01098/
Changeset:   8106aee01098
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE tests: Fix AMR grid structures: In SplitMonopole, ExactWald, MagnetoWald, and AlignedRotator tests, AMR grids did not have an integer number of gridpoints or did not properly avoid the coordinate singularity.

Affected #:  13 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/5b65ef3fe9a9/
Changeset:   5b65ef3fe9a9
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE tests: Remove "NPROCS 2" from every test in test.ccl, so that it can be run with arbitrary number of mpi tasks

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/c172280a0184/
Changeset:   c172280a0184
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE tests: Three Alfven Wave test suffered from a blowup in roundoff error due to x=0 being replaced by +/- machine epsilon at t=0. Stagger about x=0 and results are consistent across machines.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/74a46ed02283/
Changeset:   74a46ed02283
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:03+00:00
Summary:     GiRaFFE review: Prefix 'const' to *all* variables that are constant in GiRaFFE. All tests pass after fix. Also remove unused variables.

Affected #:  18 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/6d8db0161ea3/
Changeset:   6d8db0161ea3
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE review: Address remaining comments in GiRaFFE thorn. GiRaFFEfood is next.

Affected #:  7 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/83122d90c712/
Changeset:   83122d90c712
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE Review: Address comments on GiRaFFEfood.

Affected #:  4 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/5e25ed04e144/
Changeset:   5e25ed04e144
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFEfood: Address all compiler warnings.

Affected #:  12 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/8d3e845d9bb8/
Changeset:   8d3e845d9bb8
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     ID_converter_GiRaFFE: Fix compilation warnings.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/9dd7c720a20c/
Changeset:   9dd7c720a20c
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE documentation: Add the references.bib file

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/46c809919628/
Changeset:   46c809919628
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     WVUThorns/ShiftedKerrSchild: Fix compiler warning.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/9d6ed1763805/
Changeset:   9d6ed1763805
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE Review: Address remaining comments.

Affected #:  3 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/fe8864aae82e/
Changeset:   fe8864aae82e
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE Review: ID_converter_GiRaFFE/schedule.ccl: Remove [3] suffix from gridfunction group names in SYNC call. ID_converter_ILGRMHD/schedule.ccl had the same problem. Dunno why the parser didn't barf. Both fixed.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/19f5fda14cf9/
Changeset:   19f5fda14cf9
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE Review: Use srand() instead of srandom() to seed rand(). Also add comment in param.ccl explaining the use of the random_seed. Affects ID_converter_GiRaFFE *and* ID_converter_ILGRMHD.

Affected #:  4 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/39302e852f47/
Changeset:   39302e852f47
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE review: Accidentally removed random_pert variable from the ID_converter_GiRaFFE/param.ccl file. Re-add.

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/2a3c2ff082c0/
Changeset:   2a3c2ff082c0
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE review: Modifications/improvements to ShiftedKerrSchild.

Affected #:  2 files

https://bitbucket.org/zach_etienne/wvuthorns/commits/c1aebf565d84/
Changeset:   c1aebf565d84
Branch:      None
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE review: Properly prefix functions in GiRaFFEfood with GiRaFFE_

Affected #:  1 file

https://bitbucket.org/zach_etienne/wvuthorns/commits/7436f0127f56/
Changeset:   7436f0127f56
Branch:      rhaas/GiRAFFE-review
User:        zach_etienne
Date:        2018-08-31 01:58:04+00:00
Summary:     GiRaFFE review: Actually the prefix for functions inside GiRaFFEfood should be GiRaFFEfood, not GiRaFFE. Also fix some tabination issues.

Affected #:  5 files

Repository URL: https://bitbucket.org/zach_etienne/wvuthorns/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.


More information about the Commits mailing list