[ET Trac] [Einstein Toolkit] #222: Dubious code in Hydro_InitExcision.c

Einstein Toolkit trac-noreply at einsteintoolkit.org
Fri Jan 21 09:43:59 CST 2011


#222: Dubious code in Hydro_InitExcision.c
-----------------------+----------------------------------------------------
  Reporter:  eschnett  |       Owner:     
      Type:  defect    |      Status:  new
  Priority:  minor     |   Milestone:     
 Component:  Cactus    |     Version:     
Resolution:            |    Keywords:     
-----------------------+----------------------------------------------------

Comment (by eschnett):

 I attach a patch that cleans up the loop. It separates the logic of
 whether to excise from the statements that have to be executed to excise a
 grid point. It introduces local variables to simplify and document
 expressions. It also simplifies the loop structure.

 Since all Hydro_InitExcision test cases are currently failing I could not
 test the patch.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/222#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list