[ET Trac] [Einstein Toolkit] #249: Remote build broken
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Fri Jan 28 23:09:00 CST 2011
#249: Remote build broken
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: closed
Priority: blocker | Milestone:
Component: SimFactory | Version:
Resolution: fixed | Keywords:
-------------------------+--------------------------------------------------
Changes (by mthomas):
* status: new => closed
* resolution: => fixed
Comment:
fixed as of revision r1174.
It turned out to be a case where pychecker misled me. Pychecker complains
if you do a conditional and actually check for True or False, eg
if var == True. So I went through and eliminated those statements in
simfactory, replacing them with if not condition, or just if condition...
but in simopts, I had explicitly checked for boolean True in one case. I
have refactored the code to no longer check for boolean True.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/249#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list