[ET Trac] [Einstein Toolkit] #1050: [PATCH]CarpetIOHDF5: make WriteLargeAttribute write a string, not an array of ints

[Einstein Toolkit]

#1050: [PATCH]CarpetIOHDF5: make WriteLargeAttribute write a string, not an array
of ints
-------------------------------+--------------------------------------------
 Reporter:  anton@…            |       Owner:  eschnett
     Type:  defect             |      Status:  new     
 Priority:  minor              |   Milestone:          
Component:  Carpet             |     Version:          
 Keywords:                     |  
-------------------------------+--------------------------------------------
 The data that's supplied to it is to be interpreted as a string.

     Before the attached patch  the data is written as an array of int8,
 e.g.:
     h5dump -d '/Parameters and Global Attributes/Datasets' alpha.h5
     HDF5 "alpha.h5" {
     DATASET "/Parameters and Global Attributes/Datasets" {
        DATATYPE  H5T_STD_I8LE
        DATASPACE  SIMPLE { ( 16 ) / ( 16 ) }
        DATA {
        (0): 77, 76, 95, 66, 83, 83, 78, 58, 58, 97, 108, 112, 104, 97, 10,
 0
        }
     }
     }

     After the patch:
     h5dump -d '/Parameters and Global Attributes/Datasets' alpha.h5
     HDF5 "alpha.h5" {
     DATASET "/Parameters and Global Attributes/Datasets" {
        DATATYPE  H5T_STRING {
              STRSIZE 16;
              STRPAD H5T_STR_NULLTERM;
              CSET H5T_CSET_ASCII;
              CTYPE H5T_C_S1;
           }
        DATASPACE  SIMPLE { ( 1 ) / ( 1 ) }
        DATA {
        (0): "ML_BSSN::alpha
                "
        }
     }
     }

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1050>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit