[ET Trac] [Einstein Toolkit] #221: Simfactory should complain about unused arguments
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Sun Mar 4 17:30:18 CST 2012
#221: Simfactory should complain about unused arguments
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: review
Priority: major | Milestone:
Component: SimFactory | Version:
Resolution: | Keywords:
-------------------------+--------------------------------------------------
Comment (by rhaas):
Well. Yes and no. It works as well as the PETSc equivalent, which I always
found to be lacking, in that it outputs the error after the fact.
Eg.
{{{
sim create --queue development foo --configuration sim --parfile foo.bar
--procs 156 --num-threads 6 --walltime 0:10:00
}}}
will result in simfactory creating the simulation and then complaining
{{{
Error: Command line option(s) '--procs,--walltime,--queue,--num-threads'
were not used. Most likely 'create' does not support them.
}}}
On the other hand doing something like {{{sim show-output --follow foo}}}
after foo has finished will complain about {{{--follow}}} not being used
since simfactory only considers this option while a simulation is running.
The SpEC (which uses the same system) way of dealing with this is to
request these unused options anyway to pacify the OptionsParser. So maybe
a warning woud be more appropriate though warnings seem to be only output
when run with --verbose, yes?
There are ways to get to options that would not be caught (access to the
raw option string is possible) and while I would expect that no well
behaved routine does that, I have no idea of how simfactory behaves
internally.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/221#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list