[ET Trac] [Einstein Toolkit] #768: Change per thorn -DTHORN_IS_xxx to a per thorn -I bindings/include/xxx

[Einstein Toolkit]

#768: Change per thorn -DTHORN_IS_xxx to a per thorn -I bindings/include/xxx
--------------------------+-------------------------------------------------
  Reporter:  sbrandt      |       Owner:              
      Type:  enhancement  |      Status:  new         
  Priority:  optional     |   Milestone:  Cactus_4.1.0
 Component:  Cactus       |     Version:  Cactus_4.0.0
Resolution:               |    Keywords:  build system
--------------------------+-------------------------------------------------

Comment (by eschnett):

 I have a few questions on this patch. (These are just questions, not
 comments asking for action.)

 What does this line
 {{{
   my($header1,$header2,$header3, at header3,$thorn,$nthorns);
 }}}
 do? Are the Perl variables $header3 and @header3 independent, or is one
 the scalar version of the other?

 In these two lines:
 {{{
     push(@data, "#include \"$thorn/cctk_Arguments.h\"");
     push(@data, "#include \"cctk_Parameter.h\"");
 }}}
 Why is cctk_Arguments.h located in a subdirectory, but cctk_Parameter.h is
 not?

 Also: Why did you rename cctk_Schedule.h to cctk_ScheduleFunctions.h?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/768#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit