[ET Trac] [Einstein Toolkit] #1115: 'Total time for simulation' wrong for Carpet

[Einstein Toolkit]

#1115: 'Total time for simulation' wrong for Carpet
---------------------+------------------------------------------------------
  Reporter:  knarf   |       Owner:  eschnett           
      Type:  defect  |      Status:  new                
  Priority:  minor   |   Milestone:  ET_2012_11         
 Component:  Carpet  |     Version:  development version
Resolution:          |    Keywords:                     
---------------------+------------------------------------------------------

Comment (by hinder):

 This is because the corresponding timer ("CCTK total time") is stopped
 twice.  Carpet (in Shutdown.cc) stops this timer before shutdown, because
 it caused problems with PAPI (ask Erik for more details).  When Cactus
 then prints the values of the timers, including this one, with
 cctk_timer_output = "full" on shutdown, it assumes that the timer is
 running, stops it, then restarts it.  It appears that stopping a Cactus
 timer twice causes its value to double.  Instead, it should be an error.
 I propose the following changes:

 1. Stopping a Cactus timer which is not running should be an error (maybe
 a level 1 warning).
 2. The logic in Cactus ScheduleInterface.c which prints the timers at the
 end of a run should check to see if the timers are running; shutdown is a
 special case, so special-case logic is OK.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1115#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit