[ET Trac] [Einstein Toolkit] #1134: Adams-Bashforth time integrator

[Einstein Toolkit]

#1134: Adams-Bashforth time integrator
------------------------------------+---------------------------------------
  Reporter:  eschnett               |       Owner:             
      Type:  enhancement            |      Status:  reviewed_ok
  Priority:  major                  |   Milestone:             
 Component:  EinsteinToolkit thorn  |     Version:             
Resolution:                         |    Keywords:             
------------------------------------+---------------------------------------
Changes (by rhaas):

  * status:  review => reviewed_ok


Comment:

 Patch looks mostly good. Coeffs seem ok, but I only checked the 3rd order
 coeffs against the NR Adams-Bashforth-Moulton coeffs (and had previously
 checked that those are 3rd order convergent).

 Minor things:

 * it might be good to name the method "Adams-Bashforth" instead of "AB" in
 param.ccl
 * there is no test right now that the RHS variables have the required
 number of timelevels. Best would be to check in ParamCheck and to also in
 MoL_ABAdd (in case someone changed storage)
 * the AB method should be added to MoL's documentation.tex in the methods
 section. I provide a patch which really only copies the references from
 the code into the section and adds some text.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1134#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit