[ET Trac] [Einstein Toolkit] #1071: ensure atmosphere is properly set after ID

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Sep 4 13:35:06 CDT 2012

#1071: ensure atmosphere is properly set after ID
  Reporter:  knarf                  |       Owner:                     
      Type:  defect                 |      Status:  review             
  Priority:  major                  |   Milestone:  ET_2012_11         
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:                     

Comment (by rhaas):

 That schedule sounds reasonable to me. The relative density minimum would
 be computed based on the density maximum on the grid (minimum would not
 make sense I think since the minimum on the grid at that time might be
 zero), would expect. Applying atmosphere would then mean to reset all
 points where rho<grhydro_rho_min to grhydro_rho_min (using the same logic
 as in AtmosphereReset). I would avoid setting the atmosphere mask since
 atmosphere_mask is currently (somewhat counter-intuitive) mostly used to
 indicate evolution failures and not which points have density <=
 grhydro_rho (which is what I would atmosphere to mean).

 I'd be very happy if the ID schedule became less convoluted.

Ticket URL: <https://trac.einsteintoolkit.org/ticket/1071#comment:7>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit

More information about the Trac mailing list