[ET Trac] [Einstein Toolkit] #1340: simfactory does not abort --testsuite submission process if rsync fails

[Einstein Toolkit]

#1340: simfactory does not abort --testsuite submission process if rsync fails
-------------------------+--------------------------------------------------
  Reporter:  rhaas       |       Owner:  eschnett
      Type:  defect      |      Status:  new     
  Priority:  minor       |   Milestone:          
 Component:  SimFactory  |     Version:          
Resolution:              |    Keywords:          
-------------------------+--------------------------------------------------

Comment (by hinder):

 I just wanted to clarify (as I was confused initially) that Roland is
 saying that these rsyncopts are bad, not that the simfactory rsync options
 for tests are bad.  SimFactory explicitly includes the required
 cctki_MPI.h file.  The bug is that simfactory uses simlib.ExecuteCommand
 without checking its return status.  For some reason, return codes are
 being used to indicate errors, even though the language has exceptions for
 this purpose.

 The attached (untested) patch should solve the problem, assuming I didn't
 make any typos!  Does it work?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1340#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit