[ET Trac] [Einstein Toolkit] #1417: Fixed refinement levels break AMR

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Aug 6 12:46:00 CDT 2013

#1417: Fixed refinement levels break AMR
  Reporter:  coryell@…            |       Owner:  eschnett           
      Type:  defect               |      Status:  closed             
  Priority:  major                |   Milestone:                     
 Component:  Carpet               |     Version:  development version
Resolution:  fixed                |    Keywords:  CarpetRegrid2      

Comment (by rhaas):

 Works for me, both codes seem to be functionally identical. The modified
 code still regrids and passes all tests. I actually had something similar
 to what is now implemented as a first try but thought that proposing
 do_recompose = false;
 if (adaptive_refinement) do_recompose = true;
 for (int n = 0; n < num_centres; ++ n) {
 ...69 lines of code...
 likely would have had me scolded for not indenting the loop :-). The
 current code is obviously closer in style to what is used in the file

 Thank you for reviewing and committing the patch.

Ticket URL: <https://trac.einsteintoolkit.org/ticket/1417#comment:4>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit

More information about the Trac mailing list