[ET Trac] [Einstein Toolkit] #1415: GRHydro updates

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Aug 13 09:57:49 CDT 2013


#1415: GRHydro updates
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:                     
      Type:  enhancement            |      Status:  closed             
  Priority:  minor                  |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:  fixed                  |    Keywords:  GRHydro            
------------------------------------+---------------------------------------
Changes (by rhaas):

  * status:  review => closed
  * resolution:  => fixed


Comment:

 Committed 0001, 0004, 0005, 0006, 0007 (renamed GRHydro_reflvel to
 reflevel, I will not schedule the scheduled routine since I do not know
 from where con2prim will be called and would have to make very sure that
 the extra GRHydro_RefinementLevel runs just before, for just a diagnostic
 output this seems not worthwhole. Much more sensible in that case to
 simple call Carpet's GetRefinementLevel alias routine), applied 0008 using
 ash instead of lsh (making this a grid function is awkward since it is
 only used for one combination of evolution_method, evolve_mhd,
 evolve_temperature and recon_vars some of which are tested in Fortran code
 and not in schedule.ccl, 0009, 0010, 0011 removed the nested ifs, re-
 worded commit message, 0012 removing lines of code, 0013, 0014 to 0017.
 These are revs 563 - 579 of GRHydro.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1415#comment:20>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list