[ET Trac] [Einstein Toolkit] #1501: Include string null terminator in HDF5 attributes

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon Dec 9 13:53:22 CST 2013


#1501: Include string null terminator in HDF5 attributes
----------------------------+-----------------------------------------------
  Reporter:  barry.wardell  |       Owner:  eschnett           
      Type:  enhancement    |      Status:  review             
  Priority:  major          |   Milestone:                     
 Component:  Carpet         |     Version:  development version
Resolution:                 |    Keywords:                     
----------------------------+-----------------------------------------------

Comment (by barry.wardell):

 I checked Input.cc and it already avoids duplicated NUL since it
 constructs a C++ string from a C string and works from then on with the
 C++ string.

 The only place I could find a potential problem (I didn't check the VisIt
 plugin) was in CarpetIOHDF5/src/util/hdf5_slicer.cc. The updated patch
 also fixes that file so that it works in the same way as Input.cc

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1501#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list