[ET Trac] [Einstein Toolkit] #1508: abort if boundary widht is very wide (>100 points)

Einstein Toolkit trac-noreply at einsteintoolkit.org
Sat Dec 21 17:35:16 CST 2013


#1508: abort if boundary widht is very wide (>100 points)
-------------------------+--------------------------------------------------
 Reporter:  rhaas        |       Owner:                     
     Type:  enhancement  |      Status:  new                
 Priority:  minor        |   Milestone:                     
Component:  Cactus       |     Version:  development version
 Keywords:  Boundary     |  
-------------------------+--------------------------------------------------
 Currently if a user schedules the routine calling
 Boundary_RegisterGroupForBC in LEVEL mode (which is the correct mode),
 cctk_nghostzones is undefined and Carpet fills it with the deadbeef value
 (666). Passing 666 to Boundary_RegisterGroupForBC leads to silently
 incorrect results as it often prevents the BC from being applied at all
 (there is a check in many boundary routines that returns if the domain is
 too small, presumably to support 1 point wide 1d domains).

 The attached patch checks the boundary width requested and aborts if the
 width is larger than 100. This is the same threshold that the symmetry
 thorns already use to abort a run.

 This prevents a user error (seen it twice so far) and should not as far as
 I can tell affect any correct code (unless we ever actually encounter a
 boundary wider than 100 points in which case we are in trouble anyway).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1508>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list