[ET Trac] [Einstein Toolkit] #1509: ExternalLibraries do not check if patch is available

[Einstein Toolkit]

#1509: ExternalLibraries do not check if patch is available
--------------------------------------------+-------------------------------
 Reporter:  rhaas                           |       Owner:                     
     Type:  defect                          |      Status:  new                
 Priority:  minor                           |   Milestone:                     
Component:  EinsteinToolkit thorn           |     Version:  development version
 Keywords:  LORENE hwloc ExternalLibraries  |  
--------------------------------------------+-------------------------------
 some of the ExternalLibraries (LORENE, hwloc for example) use patch to
 modify the upstream source. However they do not check if patch is
 available and blindly use the flesh supplied $PATCH variable.

 Since the flesh does not abort its configuration even when patch is
 missing, this fails with an error message of the form "-p0: command not
 found".

 Either the flesh's configure should require patch to be present, or the
 ExternalLibraries need to test for PATCH being empty (there is a bash
 expansion that aborts if PATCH is undefined).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1509>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit