[ET Trac] [Einstein Toolkit] #1239: AHFinderDirect uses incorrect origin_* upon recovery when horizon was never found before

[Einstein Toolkit]

#1239: AHFinderDirect uses incorrect origin_* upon recovery when horizon was never
found before
-----------------------------------------+----------------------------------
  Reporter:  reisswig@…                  |       Owner:                
      Type:  defect                      |      Status:  review        
  Priority:  major                       |   Milestone:                
 Component:  EinsteinToolkit thorn       |     Version:                
Resolution:                              |    Keywords:  AHFinderDirect
-----------------------------------------+----------------------------------

Comment (by reisswig@…):

 Replying to [comment:4 rhaas]:
 > ok to the third reply (on numbering). Ok to the second reply in that the
 proposed behaviour is more correct. My worry was that the patchsystem
 might be left unitialized, reading the code however reveals that the
 patchsystem is unconditionally initialized with the origin_[yxz]
 parameters in AHFinderDirect_setup. It thus seems as if indeed the
 assignment in the "else" branch is superfluous but harmless since it will
 never change the values from those already set in AHFinderDirect_setup. Is
 this correct?
 >
 > Otherwise ok to apply (possibly sans comment and possibly sans the
 "else" branch).

 Agreed. I have removed and tested it without the else branch and it works
 fine.
 I can commit my changes.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1239#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit