[ET Trac] [Einstein Toolkit] #1262: simfactory doesn't know how to handle 'old' simulations

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon Feb 18 09:45:12 CST 2013


#1262: simfactory doesn't know how to handle 'old' simulations
-------------------------+--------------------------------------------------
  Reporter:  knarf       |       Owner:  eschnett           
      Type:  defect      |      Status:  review             
  Priority:  major       |   Milestone:  ET_2013_05         
 Component:  SimFactory  |     Version:  development version
Resolution:              |    Keywords:                     
-------------------------+--------------------------------------------------

Comment (by anonymous):

 It seemed to work, but only because the previous (aborted) invocation
 wrote a new output-000? directory and the next invocation didn't find an
 old simulation there and didn't try to restart but started anew. *oh
 well*.
 Btw: the same bug also caused already queued simulations to about when
 they finally started after I updated simfactory.

 This patch now works:

 {{{
 Index: lib/simlib.py
 ===================================================================
 --- lib/simlib.py       (revision 1990)
 +++ lib/simlib.py       (working copy)
 @@ -831,9 +831,10 @@
      num_smt = simenv.OptionsManager.GetOption('num-smt')
      if num_smt == None:
          if existingProperties != None:
 -            num_smt = existingProperties.numsmt
 -        else:
 -            num_smt = GetMachineOption('num-smt')
 +            try:
 +                num_smt = existingProperties.numsmt
 +            except AttributeError:
 +                num_smt = GetMachineOption('num-smt')
      try:
          num_smt = int(num_smt)
      except ValueError:
 }}}

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1262#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list