[ET Trac] [Einstein Toolkit] #1438: do not require --thornlist for build --reconfig

[Einstein Toolkit]

#1438: do not require --thornlist for build --reconfig
--------------------------+-------------------------------------------------
  Reporter:  rhaas        |       Owner:  eschnett           
      Type:  enhancement  |      Status:  review             
  Priority:  minor        |   Milestone:                     
 Component:  SimFactory   |     Version:  development version
Resolution:               |    Keywords:                     
--------------------------+-------------------------------------------------

Comment (by rhaas):

 Sigh, lost my carefully typed up summary. Here's the shorter one:

 The current code checks whether a configs/*/ThornList file exists and
 stores the result of this check hasStoredThornList however it then forces
 needThornList to be true for --rebuilds. Hence GetThornList requires an
 --thornlist option either on the command line or in the machine db. Ie.

 {{{
 sim build
 }}}
 will use the stored thornlist but
 {{{
 sim build --rebuild
 }}}
 will not and requires
 {{{
 sim build --rebuild --thornlist configs/sim/ThornList
 }}}

 I am not sure if rebuild will use configs/sim/OptionList or the option
 list from the machine db (I suspect the later). So the current behaviour
 is consistent in that --rebuild behaves as if a new configuration was
 build but it does not match well with how simfactory is actually used and
 what causes --rebuilds to be required (mostly changes that do not require
 a new ThornList).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1438#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit