[ET Trac] [Einstein Toolkit] #1609: CarpetIOHDF5 incorrectly recovers grid scalars and arrays with DISTRIB=CONSTANT

[Einstein Toolkit]

#1609: CarpetIOHDF5 incorrectly recovers grid scalars and arrays with
DISTRIB=CONSTANT
---------------------+------------------------------------------------------
 Reporter:  rhaas    |       Owner:  eschnett           
     Type:  defect   |      Status:  new                
 Priority:  blocker  |   Milestone:  ET_2014_05         
Component:  Carpet   |     Version:  development version
 Keywords:           |  
---------------------+------------------------------------------------------
 Due to the way that grid variables with DISTRIB=constant are handled, a
 recent change to Carpet (which is required to run on larger core counts)
 caused these variables to not be correctly recovered (the change was to
 add a new dimension rather than extend an existing one).

 There were two things missing: grid scalars are handled as zero
 dimensional arrays in the flesh but as 1d arrays with 1 element in the
 driver, restoring variables (arrays or scalars) did not take the new way
 of handling DISTRIB=constant into account.

 Since I have already committed fixes before and now have fixes for the
 fixes (sorry), it would be good if someone was to review them.

 The typical failure mode is that grid scalars/arrays are not fully
 recovered which in the case of grid scalars is silent (since the whole
 variable is missing which we silently ignore) leaving them with undefined
 values.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1609>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit