[ET Trac] [Einstein Toolkit] #1518: Parameter parser and CCTK_ParameterSet interpret leading zeros in numbers differently
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Fri Sep 19 08:42:08 CDT 2014
#1518: Parameter parser and CCTK_ParameterSet interpret leading zeros in numbers
differently
---------------------+------------------------------------------------------
Reporter: rhaas | Owner: sbrandt
Type: defect | Status: review
Priority: minor | Milestone:
Component: Cactus | Version: development version
Resolution: | Keywords:
---------------------+------------------------------------------------------
Comment (by sbrandt):
I said "basically the same." Since nothing in the ET test suite called it,
and (as you pointed out) the docs don't mention it I figured it wasn't
used, and open to some modification. The above function (cctk_PirahaEval),
does essentially the same thing, but returns a uExpressionValue rather
than a uExpression. I imagined a value would be more useful since the
uExpression contains internal things like tokens and token counts. Of
course, I could always rename cctk_PirahaEval as Util_ExpressionParse, but
since the return value changed I thought it might make sense to change the
name.
Do you have a thorn and test case that uses this function?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1518#comment:14>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list