[ET Trac] [Einstein Toolkit] #1799: Missing braces in test.ccl make Cactus tests hang

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon Aug 3 15:45:52 CDT 2015


#1799: Missing braces in test.ccl make Cactus tests hang
-----------------------+----------------------------------------------------
  Reporter:  eschnett  |       Owner:                     
      Type:  defect    |      Status:  new                
  Priority:  unset     |   Milestone:                     
 Component:  Cactus    |     Version:  development version
Resolution:            |    Keywords:                     
-----------------------+----------------------------------------------------

Comment (by eschnett):

 This function has several other suspicious lines:
 - It checks for {{{PROVIDES}}} in the beginning; this should likely be
 {{{TEST}}} instead
 - It uses the expression {{{$data[$line_number]}}} in one place, but
 {{{$data->[$line_number]}}} in all other places (missing arrow)
 - The outermost if...else construct looks wrong: If the first line
 contains no opening brace, then all lines until the next closing brace are
 skipped (why?); if the first line has an opening brace, then the block is
 interpreted
 - The end-of-file case is apparently not handled anywhere

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1799#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list