[ET Trac] [Einstein Toolkit] #1734: New Carpet thorns CarpetTest, TestBBoxSet2, TestTimers2

Einstein Toolkit trac-noreply at einsteintoolkit.org
Tue Jan 13 09:26:26 CST 2015


#1734: New Carpet thorns CarpetTest, TestBBoxSet2, TestTimers2
------------------------------------+---------------------------------------
  Reporter:  eschnett               |       Owner:                     
      Type:  enhancement            |      Status:  new                
  Priority:  minor                  |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:                     
------------------------------------+---------------------------------------

Comment (by hinder):

 We currently have ~14 Carpet test thorns. Each of these thorns contains
 approximately one source file each.  Why not put all such tests into
 CarpetTest?   Is there an advantage to having modularity at the level of
 thorns?  Alternatively, maybe the tests should go into the tested thorn.
 That is how the regression tests are handled, after all, and it means that
 if you have the code, you have the tests, and they will be run
 automatically.  Maybe we need to have a discussion about the best way to
 have unit tests in the ET, since we have no standards for this at the
 moment.  I would propose that unit tests should be in the tested thorn,
 and there should be a mechanism for running them as part of the regression
 tests (e.g. by having a parameter to enable each test, and a test parfile
 which activates this parameter in the thorn/test directory.

 The tests should definitely be added, but I would really prefer that we
 reduce the large number of test thorns.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1734#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list