[ET Trac] [Einstein Toolkit] #1735: support FFTW3_LIBS FFTW3_INC_DIRS FFTW3_LIB_DIRS in FFTW3 ExternalLibrary

Einstein Toolkit trac-noreply at einsteintoolkit.org
Wed Jan 14 06:19:48 CST 2015


#1735: support FFTW3_LIBS FFTW3_INC_DIRS FFTW3_LIB_DIRS in FFTW3 ExternalLibrary
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:  eschnett hinder    
      Type:  enhancement            |      Status:  reopened           
  Priority:  major                  |   Milestone:                     
 Component:  EinsteinToolkit thorn  |     Version:  development version
Resolution:                         |    Keywords:  FFTW3              
------------------------------------+---------------------------------------
Changes (by rhaas):

  * status:  reviewed_ok => reopened
  * type:  defect => enhancement


Comment:

 Uhm, actually I was mistaken in my usage of ":=" then. I had not thought
 about ${parameter=word} setting parameter if it is undefined at all.
 Having said that, I would actually prefer the behaviour of
 ${parameter=word} over ${parameter:=word} so that one can eg define an
 empty FFTW3_LIBS setting. So I'd like to amend the patch to only modify
 configuration.ccl and it is no longer a bug but just an enhancement.

 Still ok to apply?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1735#comment:4>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list