[ET Trac] [Einstein Toolkit] #1740: GRHydro ReconstructPolytype.F90 passes wrong arguments to SimplePPM(M)_1d

Einstein Toolkit trac-noreply at einsteintoolkit.org
Wed Jan 21 08:26:27 CST 2015


#1740: GRHydro ReconstructPolytype.F90 passes wrong arguments to SimplePPM(M)_1d
-----------------------------------+----------------------------------------
 Reporter:  rhaas                  |       Owner:  knarf              
     Type:  defect                 |      Status:  new                
 Priority:  major                  |   Milestone:                     
Component:  EinsteinToolkit thorn  |     Version:  development version
 Keywords:  GRHydro                |  
-----------------------------------+----------------------------------------
 Zach Etienne found (last year on August already) that

 > In GRHydro_ReconstructPoly.F90, notice that after gzz in the
 SimplePPM_1d()
 > and SimplePPM_1dM() function calls, psi4 is passed. However, if you look
 at
 > the SimplePPM_1d() and SimplePPM_1dM() routines (within
 GRHydro_PPM.F90),
 > you will find that psi4 is not a variable in the function call list, and
 > beta^i should come after gzz, for flux_direction i.

 Pull request https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-
 request/6/fix-usage-of-psi4-in-polytype/diff fixes this.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1740>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list