[ET Trac] [Einstein Toolkit] #1729: Switch Carpet to new bboxset class implementation
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Mon Jan 26 10:52:44 CST 2015
#1729: Switch Carpet to new bboxset class implementation
--------------------------+-------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: enhancement | Status: review
Priority: major | Milestone:
Component: Carpet | Version: development version
Resolution: | Keywords:
--------------------------+-------------------------------------------------
Comment (by hinder):
[Sorry Frank, I didn't read your comment carefully enough, and missed that
you had already mentioned a warning.]
To push this ticket forward, let me make a concrete suggestion:
If the user sets the CARPET_DISABLE_BBOXSET2 macro or {{{if
__cplusplus <= 199711L}}}, then fall back to the old bboxset
implementation and emit a compile-time warning that the old implementation
is being used because C++11 is not available.
This should mean that people don't have to explicitly configure for this
feature on their machine. Then, if the tests are OK, as they apparently
are, then I am happy for this to be made the default at this point in the
release cycle.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1729#comment:10>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list