[ET Trac] [Einstein Toolkit] #1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN

Einstein Toolkit trac-noreply at einsteintoolkit.org
Mon Jul 25 11:47:27 CDT 2016


#1939: Cactus: Add CCTK_VINFO, CCTK_VERROR, CCTK_VWARN
--------------------------+-------------------------------------------------
  Reporter:  eschnett     |       Owner:                     
      Type:  enhancement  |      Status:  new                
  Priority:  unset        |   Milestone:                     
 Component:  Cactus       |     Version:  development version
Resolution:               |    Keywords:                     
--------------------------+-------------------------------------------------

Comment (by rhaas):

 As far as I can tell this introduces (among other unrelated changes) a set
 of macros such that eg. {{{CCTK_VINFO("a %d", 42)}}} gets turned into
 {{{CCTK_VInfo(CCTK_THORNSTRING, "a %d", 42)}}} ie. one saves on the
 CCTK_THORNSTRING. The commit thus makes the {{{CCTK_UPPERCASE}}} macros
 more orthogonal to the corresponding {{{CCTK_LowerCase}}} functions since
 the difference between the two is now only that one set includes
 {{{CCTK_THORNSTRING}}}, {{{__LINE__}}}, {{{__FILE__}}} and the other one
 does not.

 The patch is lacking documenation updates for the new macros and should
 not be applied without.

 Comments:

 * please provide documentation for the macros in CCTK_Reference.tex
 * there are extra changes that reformat lines that are not otherwise
 touched by the commit, I would leave those out if possible

 Fine with me as long as the first point is taken care of (the second one
 is not crucial, but documentation is).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1939#comment:1>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list