[ET Trac] [Einstein Toolkit] #2053: simfactory's hard-coded rsync options override a mdb entry's rsyncopts

[Einstein Toolkit]

#2053: simfactory's hard-coded rsync options override a mdb entry's rsyncopts
------------------------+---------------------------------------------------
 Reporter:  rhaas       |       Owner:                     
     Type:  defect      |      Status:  new                
 Priority:  minor       |   Milestone:                     
Component:  SimFactory  |     Version:  development version
 Keywords:              |  
------------------------+---------------------------------------------------
 Right now, in line 165 of simfactory/lib/sim-sync.py
 {{{
    cmd = "%s --rsh=%s --rsync-path=%s %s %s %s" % (rsynccmd,
 simlib.QuoteSafe(sshcmd), simlib.QuoteSafe(machineEntry.rsynccmd),
 rsyncopts, machineEntry.rsyncopts, arguments)
     cmd = "%s %s" % (cmd, " ".join(rsyncoptions))
 }}}
 the hard-coded set of options in rsycnoptions
 {{{
     rsyncoptions = [
         '--checksum',
         '--compress',
         '--delete',
         '--hard-links',
         '--links',
         '--partial',
         '--perms',
         '--progress',
         '--recursive',
         '--sparse',
         '--stats',
         #'--times',
         '--verbose']
 }}}
 overwrites the options passed in via the mdb (machineEntry.rsyncopts)
 since it
 appears later on the commmand line.

 This is (currently) an issue for minerva, whose file system does not
 support
 hard-links, since there is no way to pass in a {{{--no-hard-links}}}
 option
 for just minerva.

 Typically we don't have hard-links in our code trees, though it is
 certainly
 not something that is expected to never happen (eg I do have some hard
 links).

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2053>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit