[ET Trac] [Einstein Toolkit] #2080: Backports for the June 2017 release to compile on the NDS machine

Einstein Toolkit trac-noreply at einsteintoolkit.org
Thu Oct 12 05:30:29 CDT 2017


#2080: Backports for the June 2017 release to compile on the NDS machine
--------------------------+-------------------------------------------------
  Reporter:  sbrandt      |       Owner:                     
      Type:  enhancement  |      Status:  reopened           
  Priority:  critical     |   Milestone:                     
 Component:  Other        |     Version:  development version
Resolution:               |    Keywords:                     
--------------------------+-------------------------------------------------
Changes (by rhaas):

  * status:  review => reopened


Comment:

 Looking at generic.cfg in 5258cc455e06d90584708e1f62a2b3fc87b569bc which
 seems to be the one you want to backport (technically the change to master
 would also have required review):

 * maybe better to use gnu++0x rather than c++0x so that _GNU_SOURCE is
 automatically defined
 * it is possible to compile Cactus (PUGH for example) without the F90
 compiler which is why there is no default F90 compiler. So adding the
 requirement is a bit of a policy decision (should be fine but should be
 mentioned and not done without comment).
 * "F90_OPENMP_FLAGS = -pg" seems wrong. Do you mean to use either
 F90_PROFILE_FLAGS or "-fopenmp"?
 * same later on for F90_OPENMP_FLAGS
 * please do not make generic.run into a script that can use MPI code, we
 already have generic-mpi.run for this

 The proposed change to bin/sim seems like a bugfix to me while the others
 are enhancements.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2080#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list