[ET Trac] [Einstein Toolkit] #2080: Backports for the June 2017 release to compile on the NDS machine
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Thu Oct 12 06:40:38 CDT 2017
#2080: Backports for the June 2017 release to compile on the NDS machine
--------------------------+-------------------------------------------------
Reporter: sbrandt | Owner:
Type: enhancement | Status: reopened
Priority: critical | Milestone:
Component: Other | Version: development version
Resolution: | Keywords:
--------------------------+-------------------------------------------------
Comment (by sbrandt):
Sorry. The F90_OPENMP_FLAGS was, obviously, a copy paste error. I made a
similar mistake on the warn files. Here's the corrected version (if you
approve).
{{{
diff --git a/mdb/optionlists/generic.cfg b/mdb/optionlists/generic.cfg
index 489e60d..ea82618 100644
--- a/mdb/optionlists/generic.cfg
+++ b/mdb/optionlists/generic.cfg
@@ -16,7 +16,7 @@ CPPFLAGS =
FPPFLAGS = -traditional
CFLAGS = -g -std=gnu99
-CXXFLAGS = -g -std=c++0x
+CXXFLAGS = -g -std=gnu++0x
F77FLAGS = -g -fcray-pointer -ffixed-line-length-none
F90FLAGS = -g -fcray-pointer -ffixed-line-length-none
@@ -36,15 +36,15 @@ PROFILE = no
CPP_PROFILE_FLAGS =
C_PROFILE_FLAGS = -pg
CXX_PROFILE_FLAGS = -pg
-F77_OPENMP_FLAGS = -pg
-F90_OPENMP_FLAGS = -pg
+F77_PROFILE_FLAGS = -pg
+F90_PROFILE_FLAGS = -pg
WARN = yes
CPP_WARN_FLAGS = -Wall
C_WARN_FLAGS = -Wall
CXX_WARN_FLAGS = -Wall
-F77_OPENMP_FLAGS = -Wall
-F90_OPENMP_FLAGS = -Wall
+F77_WARN_FLAGS = -Wall
+F90_WARN_FLAGS = -Wall
OPENMP = yes
CPP_OPENMP_FLAGS = -fopenmp
}}}
I thought the policy on cfg files was, generally, not to make a ticket.
Since generic.cfg didn't work anyway, it seemed harmless.
Why should we have two versions of generic, one that can call mpi and one
that cannot? Why not have one script that only tries to use mpi if more
than one process is called for? If we have two scripts, then we should
have simfactory detect whether mpi is present and install the correct one.
Is that what you would prefer?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2080#comment:3>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list