[ET Trac] [Einstein Toolkit] #2106: Make ParseFile.c more robust
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Mon Mar 12 13:12:42 CDT 2018
#2106: Make ParseFile.c more robust
-----------------------+----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: reopened
Priority: unset | Milestone:
Component: Cactus | Version: development version
Resolution: | Keywords:
-----------------------+----------------------------------------------------
Comment (by rhaas):
Probably yes. I just hope that changing to {{{signed long}}} does not
create a host of new warnings about mixing singed and unsigned types in
the remainder of the code. Sorry for being so picky about all of this, in
particular since this is all a very minor part of the code (is it even
still used by the piraha parser code?) and the discussion by now has taken
much more time than writing the patch likely did. The original patch
though I think did have an actual bug in the comparison of {{{*filesize}}}
to {{{<0}}}, so the review, mostly anyway, served its intended purpose of
catching bugs.
Would it be possible to update the pull request with the actual proposed
change, please? Otherwise it seems to me that there is some danger of not
quite agreeing on the same thing to commit.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2106#comment:13>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list