[ET Trac] #2602: include Regge-Wheeler-Zerilli gauge self-force code in ET

[Peter Diener]

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET

 Reporter: Samuel Cupp
   Status: new
Milestone: ET_2022_05
  Version: development version
     Type: enhancement
 Priority: major
Component: Other

Comment (by Peter Diener):

I have carefully checked the source code and have the following comments and requests for changes at this time:

module\_scalar\_rwz.f90 should be renamed to module\_rwz\_schw.f90

submodule\_scalar\_rwz\_implementation.f90 should be renamed to  
submodule\_rwz\_schw\_implementation.f90

In module\_scalar\_rwz.f90:

Line 16: The ford link \[\[submodule\_scalar\_schw\_implementation.f90\]\] should be  
changed tp \[\[submodule\_rwz\_schw\_implementation.f90\]\]

Line 29: Ford comment should not say scalar field and point charge but rather  
RWZ metric perturbations and point mass.

Line 76: \[\[scal\_schw\_save\_globals\_1\]\] should be \[\[rwz\_schw\_save\_globals\_1\]\]

Line 79: \[\[scal\_schw\_save\_globals\_2\]\] should be \[\[rwz\_schw\_save\_globals\_2\]\]

Line 82: \[\[scal\_schw\_load\_globals\]\] should be \[\[rwz\_schw\_load\_globals\]\]

Line 85: \[\[scal\_schw\_apply\_filter\]\] should be \[\[rwz\_schw\_apply\_filter\]\]

Line 87: \[\[scal\_schw\_flux\]\] should be \[\[rwz\_schw\_flux\]\]

Line 88: \[\[scal\_schw:flux\]\] should be \[\[rwz\_schw:flux\]\]

Lines 93-98: Why 2 functions for outputting coordinates for initial data codes?

Line 133: \[\[scal\_schw\]\] should be \[\[rwz\_schw\]\]

Line 141: \[\[scal\_schw\]\] should be \[\[rwz\_schw\]\]

Line 149: \[\[scal\_schw\]\] should be \[\[rwz\_schw\]\]

Line 157: \[\[scal\_schw\]\] should be \[\[rwz\_schw\]\]

Line 164: \[\[scal\_schw\_flux\]\] should be \[\[rwz\_schw\_flux\]\]

Line 165: \[\[scal\_schw:flux\]\] should be \[\[rwz\_schw:flux\]\]

Line 177-192: Again, as above, we two versions of the routine to write out  
coordinates for the initial data code.

In submodule\_scalar\_rwz\_implementation.f90:

Line 52: The allocation of the equation name character variable should be  
of length 8 rather than 18.

Line 325: Why is the code for settinp up an initial Gaussian profile commented  
out when use\_particle is .false.?

Line 352-360: As we currently only have an effective source for circular  
orbits, the code should abort with an error message if use\_generic\_orbit is  
.true.

Line 403-417: As we currently only have an effective source for circular  
geodesic orbits, we should comment out these lines and replace it with  
accel= 0.0\_wp

Line 497-506: All of these can be commented out until we can extract the  
self-force

Line 535-548: All of these can be commented out until we can extract the  
self-force

Line 557-580: All of these can be commented out until we can support generic  
orbits

Line 661-662: Use the features of output\_base to get unique file unit numbers  
instead of using hardcoded 10 and 11. In subsequent lines in the loop use  
those unique file unit numbers.

Line 702-704: Use the features of output\_base to get unique file unit numbers  
instead of using hardcoded 12.

Line 724-725: Use the features of output\_base to get unique file unit numbers  
instead of using hardcoded 10 and 11. In subsequent lines in the loop use  
those unique file unit numbers.

Line 765-767: Use the features of output\_base to get unique file unit numbers  
instead of using hardcoded 12.

Line 1000-1003: The Ford comment still refers to the scalar case. Please change  
it to reflect what is done in the RWZ case.

Line 1034: The expression does not take lmin into account. Is it not possible  
to evolve with a non-default lmin value? Does the expression assume lmin=2

In input.f90: This file does not seem to be used. Remove?

In Observers/RWZFlux: I would prefer if all subroutine names start with flux\_  
instead of flx\_.

In Observers/RWZMetric: I would prefer if all subroutine names start with  
metric\_ instead of met\_.

In Observers/RWZStrain: I would prefer if all subroutine names start with  
strain\_ instead of str\_.

‌

Once the ford comment issues have been fixed, I can then try to generate the documentation for the new routines.

Finally, some test cases should be constructed and be added to the Test directory for automatic regression testing.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-wheeler-zerilli-gauge-self
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20220908/9b7b7536/attachment.html