[ET Trac] #2692: Inclusion of FUKA importer thorns

[Roland Haas]

#2692: Inclusion of FUKA importer thorns

 Reporter: tootle
   Status: new
Milestone: ET_2023_05
  Version: ET_2023_05
     Type: proposal
 Priority: major
Component: EinsteinToolkit thorn

Comment (by Roland Haas):

In the current KadathThorn, there is a `.gitmodules` file:  

```
[submodule "src/fuka"]
	path = src/fuka
	url = https://bitbucket.org/fukaws/fuka/
[submodule "fuka"]
	branch = fuka
```

for the fuka library checked out into `src/fuka` as a git submodule. This all works and is fine.

However I notice that you are also including a section:  

```
[submodule "fuka"]
	branch = fuka
```

which will be ignored since there is no `fuka` submodule \(the submodule is `src/fuka`\). Moreover, if it was _not_ ignored, it would actually be an issue for the ET unless it is removed or fixed to a `ET_YYYY_MM` branch for each release branch and fixed to a specific git hash for each `ET_YYYY_MM_vN` release tag. Otherwise it points to the _current_ head of that branch which is not what one would want for an ET release branch or tag \(which should point to the specific, tested version that was released\). 

Since it is ignored anyway, it may be best to remove this section altogether to not give any false impression on what commit of `fuka` is actually checked out.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka-importer-thorns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20230401/b10230b0/attachment.html