[ET Trac] #2692: Inclusion of FUKA importer thorns

[tootle]

#2692: Inclusion of FUKA importer thorns

 Reporter: tootle
   Status: new
Milestone: ET_2023_05
  Version: ET_2023_05
     Type: proposal
 Priority: major
Component: EinsteinToolkit thorn

Comment (by tootle):

@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} @{63ee64f4a4fdf0935c886bb1}   
I have put some effort into the KadathThorn which handles ensuring the kadath library exists and, if not, will be built along with all the other thorns.  This still requires that the user has a compiler that is compatible with the C\+\+17 standard and std::filesystem.

I have added quite some output during the build process to let the user know that HOME\_KADATH will need to be set in their submit script along with the directory to use.  I’m not sure if there is a good way to include this in the basic simfactory files?  Maybe @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} has a good idea for this since I never use simfactory. It is worth noting that this isn’t critical other than to utilize `${HOME_KADATH}/eos` for using the built-in EOS files for 1D tables and polytropes.

@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} : Additionally, I would prefer to avoid having a tarball of the library that is separately packaged and stored as an ExternalLibrary.  To avoid this - during the build procedure for KadathThorn \(if FUKA needs to be built\) - the build script will pull the fuka submodule.  I’m not sure if this goes against any best practices that ETK tries to adhere by, but it worked quite well from a testing/build standpoint.

@{63ee64f4a4fdf0935c886bb1} :  The thorns are more or less in a final place, but I still need to write the documentation.  I don’t think this will impact you though given your familiarity with the codes.  The thing I would note is that in the KadathImporter there is now a test directory that includes a quick test using preexisting BH initial data.  The only output is from AHFinder where one can see the BH mass matches the ID in the info file.  I have also included a semi-minimum thornlist needed to run the test along with the cfg and sub scripts that I used to build ETK and submit the test job.  The build procedure and test was performed on my laptop.  The test, using 4 ranks, took ~2min.

Cheers

P.S. The latest of both thorns can be obtained by adding the following to a standard thornlist:

```none
# fuka thorns
!TARGET   = $ARR
!TYPE     = git
!URL      = https://bitbucket.org/fukaws/$2
!REPO_PATH=../$2
!CHECKOUT =
Fuka/KadathImporter
#disabled fuka/kadathpizza
Fuka/KadathThorn
```

‌

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka-importer-thorns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/trac/attachments/20230218/9263e7a6/attachment.html