[ET Trac] #2871: EOS_Omni's nuceos code used int to hold hid_t values

Erik Schnetter trac-noreply at einsteintoolkit.org
Thu Jul 17 08:34:35 CDT 2025


#2871: EOS_Omni's nuceos code used int to hold hid_t values

 Reporter: Roland Haas
   Status: open
Milestone: 
  Version: 
     Type: bug
 Priority: major
Component: EinsteinToolkit thorn

Comment (by Erik Schnetter):

I recommend two further changes for safety:

* Add parentheses around `fn_call`
* Add a `do { } while (0)` construct around the current `if` construct. I’m not sure whether the current `if` construct is working as expected if it is followed directly by an `else` keyword.

Approved.

‌

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2871/eos_omnis-nuceos-code-used-int-to-hold
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.einsteintoolkit.org/pipermail/trac/attachments/20250717/3d3eccec/attachment-0001.htm>


More information about the Trac mailing list