[ET Trac] #2901: ExternalLibraries-ADIOS2: detect.sh adds nonexistent MPI libraries if ADIOS2_ENABLE_SST == yes when using external ADIOS2

[Miren Radia]

#2901: ExternalLibraries-ADIOS2: detect.sh adds nonexistent MPI libraries if ADIOS2_ENABLE_SST == yes when using external ADIOS2

 Reporter: Miren Radia
   Status: submitted
Milestone: 
  Version: development version
     Type: bug
 Priority: minor
Component: EinsteinToolkit thorn

I opened [an issue in the GitHub repository](https://github.com/EinsteinToolkit/ExternalLibraries-ADIOS2/issues/8) but am opening this ticket here as suggested by Roland Haas. The GitHub issue description is below  
  
In the case \`ADIOS2\_ENABLE\_SST == yes\`, after [this line](https://github.com/EinsteinToolkit/ExternalLibraries-ADIOS2/blob/c45b71f75756a2d4d7d9bf6f8cee3b502dc6fea7/src/detect.sh#L51)

\`\`\`bash  
ADIOS2\_REQ\_LIBRARIES="adios2\_cxx11 adios2\_c adios2\_core adios2\_evpath adios2\_atl adios2\_enet adios2\_ffs adios2\_dill"  
\`\`\`

\(maybe with a fortran one too depending on that config option\). Then [later on](https://github.com/EinsteinToolkit/ExternalLibraries-ADIOS2/blob/c45b71f75756a2d4d7d9bf6f8cee3b502dc6fea7/src/detect.sh#L85-87), all of these libraries are appended by \`\_mpi\` so the full library list looks something like

\`\`\`  
ADIOS2\_LIBS="adios2\_cxx11\_mpi adios2\_c\_mpi adios2\_core\_mpi adios2\_evpath\_mpi adios2\_atl\_mpi adios2\_enet\_mpi adios2\_ffs\_mpi adios2\_dill\_mpi adios2\_cxx11 adios2\_c adios2\_core adios2\_evpath adios2\_atl adios2\_enet adios2\_ffs adios2\_dill"  
\`\`\`

Unfortunately, looking at my Spack build of ADIOS2, I only have the following in the \`lib64\` directory \(actually it's the same as the one built by Cactus using the \`build.sh\` script\):

\`\`\`  
cmake            libadios2\_c.a      libadios2\_core.a      libadios2\_cxx11.a      libadios2\_dill.a  libadios2\_evpath.a libadios2\_atl.a  libadios2\_c\_mpi.a  libadios2\_core\_mpi.a  libadios2\_cxx11\_mpi.a  libadios2\_enet.a  libadios2\_ffs.a  
\`\`\`

I think only \`adios2\_cxx11 adios2\_c adios2\_core\` \(and \`adios2\_fortran\` if enabled\) should be appended by \`\_mpi\`.

Note that it seems to be correct in the case ADIOS2 is built rather than using an external library \(see [here](https://github.com/EinsteinToolkit/ExternalLibraries-ADIOS2/blob/c45b71f75756a2d4d7d9bf6f8cee3b502dc6fea7/src/detect.sh#L122-L125)\).

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2901/externallibraries-adios2-detectsh-adds
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.einsteintoolkit.org/pipermail/trac/attachments/20251117/234997fa/attachment.htm>