[ET Trac] #2946: CarpetX includes `<omp.h>` when OpenMP is not enabled

[Maxwell Rizzo]

#2946: CarpetX includes `<omp.h>` when OpenMP is not enabled

 Reporter: Maxwell Rizzo
   Status: new
Milestone: 
  Version: 
     Type: bug
 Priority: minor
Component: CarpetX

Two files, `CarpetX/src/driver.cxx` at [L22](https://github.com/EinsteinToolkit/CarpetX/blob/8883b4199b26f0f6bd41d41c0ba5b94d46e84b51/CarpetX/src/driver.cxx#L22) and `.../boundaries.cxx` at [L9](https://github.com/EinsteinToolkit/CarpetX/blob/8883b4199b26f0f6bd41d41c0ba5b94d46e84b51/CarpetX/src/boundaries.cxx#L9), include `<omp.h>` without checking whether `_OPENMP` is defined, unlike other CarpetX files such as `CarpetX/src/schedule.cxx` at [L19](https://github.com/EinsteinToolkit/CarpetX/blob/8883b4199b26f0f6bd41d41c0ba5b94d46e84b51/CarpetX/src/schedule.cxx#L19). This always includes OpenMP when compiling CarpetX, which can cause compile time failure for systems that do not provide OpenMP, even with OpenMP disabled.

This bug was encountered when compiling CarpetX while OpenMP is not enabled with macOS Clang, which does not provide OpenMP by default.

--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2946/carpetx-includes-when-openmp-is-not
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.einsteintoolkit.org/pipermail/trac/attachments/20260520/63d38593/attachment.htm>