[Users] Possible Patch for GetComponents

Erik Schnetter schnetter at cct.lsu.edu
Sun Jun 20 13:53:49 CDT 2010


On Jun 18, 2010, at 19:54 , Frank Loeffler wrote:

> Hi Eric,
> 
> On Fri, Jun 18, 2010 at 03:51:21PM -0500, Eric Seidel wrote:
>> Let me know what you think,
> 
> The patch (please attach it as file next time) does not only fix the issue
> you mentioned, but also fixes some issues connected with the --date
> option. While this is great, it helps a reviewer to mention everything a
> patch does.
> 
> Having said that, the patch looks good and it didn't show the error
> message the old version did when I tested it. Nice work, please apply.

To avoid confusion which version of "the" stable version people are using, we should probably accumulate several patches in the stable branch before releasing the next version, and then increase a version number (e.g. to ET_2010_06b).  This isn't possible with the current setup, where people check out the tip of the release branch.  In the future, we will probably want to point to a release tag, so that we can use the release branch for testing patches, and then create a new, different release tag once things work.

Most people won't update their stable version once they have it.  If this patch is really important, we will need to announce it widely, and ask people to update if we decide it is important.

For the time being, I would hold off committing any changes to the release branch until we've discussed this in more detail.  Eric, can you wait until Monday?

-erik

-- 
Erik Schnetter <schnetter at cct.lsu.edu>   http://www.cct.lsu.edu/~eschnett/





More information about the Users mailing list