[Users] [Commits] [svn:einsteintoolkit] ADMMacros/trunk/src/macro/ (Rev. 107)

[Ian Hinder]

On 5 Nov 2010, at 17:13, Frank Loeffler wrote:

> Hi,
>
> On Fri, Nov 05, 2010 at 08:41:45AM +0100, Ian Hinder wrote:
>> Good catch!  Does this mean that the testsuite results were wrong all
>> along, and now have to be regenerated?
>
> Yes. They have been committed by now. (There was some permission issue
> to sort out, which is why it took a bit.)
>
>> What other codes would have been affected?  For example, BSSN_MoL?
>
> Maybe. Potentially everything which included that file twice in the  
> same
> file.
>
>> Again I repeat my call for correctness tests in addition to  
>> regression
>> tests...
>
> I agree. This morning we found another testsuite which has completely
> wrong result data and Roland is about to fix this.


Which one was that?

I have also noticed that the WeylScal4 test is newly failing as of  
last night.  I modified the parameter files yesterday to remove the  
Carpet::poison_value parameter as the new Mercurial version of Carpet  
doesn't understand that parameter.  The test passed on my laptop so I  
committed the new parameter file, but it seems to fail with NaNs on  
Damiana.  I'm looking into it now.  It could also theoretically have  
been caused by some other change that happened yesterday.

-- 
Ian Hinder
ian.hinder at aei.mpg.de