[Users] [ET Trac] [Einstein Toolkit] #344: Checkpointing + new cleanup procedure

[Erik Schnetter]

On Mon, Mar 14, 2011 at 5:40 PM, Einstein Toolkit
<trac-noreply at einsteintoolkit.org> wrote:
> #344: Checkpointing + new cleanup procedure
> -------------------------+--------------------------------------------------
>  Reporter:  mthomas      |       Owner:  mthomas
>     Type:  enhancement  |      Status:  new
>  Priority:  blocker      |   Milestone:
> Component:  SimFactory   |     Version:
>  Keywords:               |
> -------------------------+--------------------------------------------------
>  Attached to this ticket is the patch to fix checkpointing (which Ian has
>  already reviewed) plus code implementing the new cleanup procedure.

Michael

You can commit the original patch that you proposed. For this, you
could have a fresh checkout of Simfactory around (which is a good idea
anyway), apply the patch there, and then commit. Since the patch is
fresh, this should work without much trouble.

If you then update your other working tree (with the additional
changes), you should be able to distill a new patch with just the
cleanup changes. This works out of the box many times; if the changes
are intertwined, this requires some manual work.

-erik

>  The new cleanup procedure is thus:
>
>  1. Automatic cleanup of every simulation is now gone.
>  2. Any command that creates a new restart (submit, user initiated run)
>  calls restartlib.CleanupSimulation on that specific simulation, and
>  CleanupSimulation will only attempt to do cleanup if it finds an active
>  restart for that given simulation
>  3. sim cleanup without any arguments will cleanup all simulations. If you
>  specify a specific simulation, it will only clean up that one.
>
>  Still needing to be implemented are the times when cleanup of all
>  simulations should happen, or the cleanup when a simulation finishes.
>  These need to be done via cronjobs or some other method that hasn't quite
>  been figured out yet. Please svn up to get the latest revision (I
>  committed a bunch of very trivial code changes) then apply this patch and
>  add comments to this ticket related to this patch.
>
> --
> Ticket URL: <https://trac.einsteintoolkit.org/ticket/344>
> Einstein Toolkit <http://einsteintoolkit.org>
> The Einstein Toolkit
> _______________________________________________
> Trac mailing list
> Trac at einsteintoolkit.org
> http://lists.einsteintoolkit.org/mailman/listinfo/trac
>



-- 
Erik Schnetter <schnetter at cct.lsu.edu>   http://www.cct.lsu.edu/~eschnett/