[Users] Missing thorns in ET_2013_05 branch

[Ian Hinder]

On 11 May 2013, at 21:48, Erik Schnetter <schnetter at cct.lsu.edu> wrote:

> I test them regularly. They build fine on many systems (but not all).
> 
> The reason we commented them out was that they take a long time to build, while no standard ET thorn uses them. Please include them in the release.

Hi Erik,

Do you mean to included them in the release, but commented-out in the thornlist, or to uncomment them in the thornlist?

If they are in the release, we need to test them as part of the usual process.  This will be awkward if they are commented out.  Everyone will have to remember to uncomment them before running the tests. The automated test system also doesn't know that they should be tested.

> 
> -erik
> 
> 
> On Sat, May 11, 2013 at 3:21 PM, Frank Loeffler <knarf at cct.lsu.edu> wrote:
> On Sat, May 11, 2013 at 01:49:34PM -0400, Erik Schnetter wrote:
> > CactusElliptic/EllPETSc
> > CactusTest/TestAllTypes
> > ExternalLibraries/PETSc
> > TAT/TATPETSc
> 
> Right. That's because they are commented out in the standard thornlist.
> Is this so because they don't build in a lot of places? With them being
> commented out they very likely don't receive much testing...
> 
> Frank
> 
> 
> 
> 
> -- 
> Erik Schnetter <schnetter at cct.lsu.edu>
> http://www.perimeterinstitute.ca/personal/eschnetter/
> _______________________________________________
> Users mailing list
> Users at einsteintoolkit.org
> http://lists.einsteintoolkit.org/mailman/listinfo/users

-- 
Ian Hinder
http://numrel.aei.mpg.de/people/hinder

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.einsteintoolkit.org/pipermail/users/attachments/20130512/71eabb1f/attachment-0001.html