[Users] how to review a contribution guideline
Roland Haas
rhaas at illinois.edu
Wed Aug 10 11:38:47 CDT 2022
Hello all,
I added "ask for a gallery example" as an optional requirement to the
draft:
https://docs.einsteintoolkit.org/et-docs/How_to_Review_a_new_component#Optional_criteria
Yours,
Roland
> Gabriele
>
> This is an excellent idea.
>
> My usual criteria would be:
> - needs to have a "getting started" document
> - needs to have example output that can be reproduced
> A gallery example implies both.
>
> -erik
>
>
> On Tue, Aug 2, 2022 at 11:17 AM Roland Haas <rhaas at illinois.edu> wrote:
> >
> > Hello all,
> >
> > Since I am serving as release manager for the upcoming release and
> > could not find this information collated in a single location I started
> > to draft a reviewer's guide for contributions (slightly different from
> > the how to review a patch guide
> > https://urldefense.com/v3/__https://docs.einsteintoolkit.org/et-docs/How_to_Review_a_Patch__;!!DZ3fjg!5ShQVlCnpQncjV3BkINCorG82NQQcVd8jgWedRB-dyWZphwW_w_jJ7I3rKWoX5qjpT1RdQ08lFXlJYTnwA$ that
> > already existed):
> >
> > https://urldefense.com/v3/__https://docs.einsteintoolkit.org/et-docs/How_to_Review_a_new_component__;!!DZ3fjg!5ShQVlCnpQncjV3BkINCorG82NQQcVd8jgWedRB-dyWZphwW_w_jJ7I3rKWoX5qjpT1RdQ08lFWSGztzbg$
> >
> > Comments and contributions (you may have to send email first to have an
> > account on the wiki created) would be very welcome.
> >
> > Yours,
> > Roland
> >
> > --
> > My email is as private as my paper mail. I therefore support encrypting
> > and signing email messages. Get my PGP key from https://urldefense.com/v3/__http://pgp.mit.edu__;!!DZ3fjg!5ShQVlCnpQncjV3BkINCorG82NQQcVd8jgWedRB-dyWZphwW_w_jJ7I3rKWoX5qjpT1RdQ08lFUP_CFcBA$ .
> > _______________________________________________
> > Users mailing list
> > Users at einsteintoolkit.org
> > https://urldefense.com/v3/__http://lists.einsteintoolkit.org/mailman/listinfo/users__;!!DZ3fjg!5ShQVlCnpQncjV3BkINCorG82NQQcVd8jgWedRB-dyWZphwW_w_jJ7I3rKWoX5qjpT1RdQ08lFWk8C5zNw$
>
>
>
--
My email is as private as my paper mail. I therefore support encrypting
and signing email messages. Get my PGP key from http://pgp.mit.edu .
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
Url : http://lists.einsteintoolkit.org/pipermail/users/attachments/20220810/b5228a32/attachment.bin
More information about the Users
mailing list