[ET Trac] [Einstein Toolkit] #69: Formaline might stop build because of errors reported by tar

[Einstein Toolkit]

#69: Formaline might stop build because of errors reported by tar
--------------------+-------------------------------------------------------
 Reporter:  knarf   |       Owner:            
     Type:  defect  |      Status:  new       
 Priority:  major   |   Milestone:  ET_2010_11
Component:  Cactus  |     Version:            
 Keywords:          |  
--------------------+-------------------------------------------------------
 Beginning with version 1.16 of gnu tar:
 <quote>
 After creating an archive, tar exits with code 1 if some files were
 changed while being read.  Previous versions exited with code 2 (fatal
 error), and only if some files were truncated while being archived.
 </quote>

 Even reading a file (as is done when compiling it in parallel) will change
 it in tar's view, because this changes the atime of the file. There does
 not seem to be an option which turns this new behavior off. Instead it is
 recommended to check the exit code of tar which is
 0: if everything went ok
 1: if files changed while being read/written
 2: if some other error occurs.

 This means that Formaline should treat an exit code of 1 in tar as 'ok',
 while currently it aborts the build. However, this is safely true only for
 gnu tar. For example the version of tar on the 'pelican' system states:
 <quote>
 0 Successful completion.
 >0 An error occurred.
 </quote>
 This is too vague to decide if ignoring an exit code of 1 can also here be
 ignored. File changes are a kind of error - of a kind one might be able to
 ignore. The documentation of this old version of tar doesn't mention which
 values are actually used for which errors though.

 Somewhere else I found [http://aplawrence.com/Bofcusm/2073.html this]:
 <quote>
 0 - success
 1 - bad directory tree, failed to extract a requested file,
     input file same as output file, failed to open input file,
     could not create link, link table malloc  failure
 2 - internationalization error that should never occur,
     checksum error
 5 - checksum error
 9 (EBADF) - error reading /etc/default/tar, misplaced end of volume
 </quote>

 So, it is probably not safe to assume that an exit value of 1 always means
 'success' for any version of tar, in the case of Formaline. How should we
 proceed with Formaline? The current state is not desirable. As far as I
 can see we have two options:

 1) Assume that an exit value of 1 to be a 'success'. I do have a patch for
 this.
 2) Test for gnu tar and only then assume 1)

 Opinions?

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/69>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit