[ET Trac] [Einstein Toolkit] #682: LSUThorns/Vectors: Simplify API for partial vector stores

Einstein Toolkit trac-noreply at einsteintoolkit.org
Sat Feb 4 08:24:30 CST 2012


#682: LSUThorns/Vectors: Simplify API for partial vector stores
------------------------------------+---------------------------------------
  Reporter:  eschnett               |       Owner:        
      Type:  enhancement            |      Status:  review
  Priority:  major                  |   Milestone:        
 Component:  EinsteinToolkit thorn  |     Version:        
Resolution:                         |    Keywords:        
------------------------------------+---------------------------------------

Comment (by barry.wardell):

 It looks like you have two "else if (v8stp_lo)" in the SSE4A part of the
 patch. Should the second of these be "else if (v8stp_hi)"? If so,would the
 tests have picked this up on an SSE4A machine? If so, and the AVX code
 also pases the test, I think this should be applied. I'd also recommend
 adding a pseudo-code comment explaining what the AVX version does.

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/682#comment:2>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list