[ET Trac] [Einstein Toolkit] #759: No helpful error messages if soucebasedir points to a non Cactus sources directory

[Einstein Toolkit]

#759: No helpful  error messages if soucebasedir points to a non  Cactus sources
directory
------------------------+---------------------------------------------------
 Reporter:  alibeck     |       Owner:  eschnett
     Type:  defect      |      Status:  new     
 Priority:  major       |   Milestone:          
Component:  SimFactory  |     Version:          
 Keywords:              |  
------------------------+---------------------------------------------------
 If the path of sourcebasedir points to a directory which does not content
 a Cactus directory, simfactory exits with an error as:

 [snip]
 Traceback (most recent call last):
   File "simfactory/bin/../lib/sim.py", line 147, in <module>
     main()
   File "simfactory/bin/../lib/sim.py", line 143, in main
     CommandDispatch()
   File "simfactory/bin/../lib/sim.py", line 105, in CommandDispatch
     module.main()
   File "/home/alibeck/Cactus-Mojave-Test/Cactus/simfactory/lib/sim-
 manage.py",
 line 397, in main
     CommandDispatch()
   File "/home/alibeck/Cactus-Mojave-Test/Cactus/simfactory/lib/sim-
 manage.py",
 line 376, in CommandDispatch
     exec("command_%s()" % command)
   File "<string>", line 1, in <module>
   File "/home/alibeck/Cactus-Mojave-Test/Cactus/simfactory/lib/sim-
 manage.py",
 line 154, in command_create_submit
     command_create()
   File "/home/alibeck/Cactus-Mojave-Test/Cactus/simfactory/lib/sim-
 manage.py",
 line 133, in command_create
     restart.create(simulationName, parfile)
   File "/home/alibeck/Cactus-Mojave-
 Test/Cactus/simfactory/lib/simrestart.py",
 line 1192, in create
     sourcedir = simlib.BuildPath(localsourcebasedir, dirsuffix)
   File "/home/alibeck/Cactus-Mojave-Test/Cactus/simfactory/lib/simlib.py",
 line 676, in BuildPath
     return os.sep.join(args)
 TypeError: sequence item 1: expected string, NoneType found
 [snip]

 Such an error message does not really help an user. It occurs either if
 the --sourcebasedir option is used on the command line, or in the default
 settings (machine file) or in defs.local.ini

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/759>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit