[ET Trac] [Einstein Toolkit] #1518: Parameter parser and CCTK_ParameterSet interpret leading zeros in numbers differently
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Thu Jan 16 22:03:08 CST 2014
#1518: Parameter parser and CCTK_ParameterSet interpret leading zeros in numbers
differently
---------------------+------------------------------------------------------
Reporter: rhaas | Owner: sbrandt
Type: defect | Status: reopened
Priority: minor | Milestone:
Component: Cactus | Version: development version
Resolution: | Keywords:
---------------------+------------------------------------------------------
Comment (by rhaas):
Replying to [comment:5 sbrandt]:
> After digging in to this deeper, it seems the real problem is that
Piraha integration was incomplete. Util_ExpressionEvaluate() is still used
when expressions are set internally.
We have actually list of leftover TODO items for Piraha (meeting minutes:
http://lists.einsteintoolkit.org/pipermail/users/2013-February/002854.html)
for which we unfortunately never created a ticket so they got lost it
seems.
Piranha parameter parser:
* currently parses only parameter files, plan to extent to all ccl files
* should use namespace and adhere to Cactus naming and commenting
conventions: either use C++ namespace cctk (and cctki?) and/or prefix all
externally visible functions by either cctk or cctki depending on whether
they should be user callable or not [NOTE: these are lowercase but they
should have been uppercase CCTK (RH)]
* remove and replace existing math evaluator/parser by piranha one to have
uniform math support
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1518#comment:7>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list