[ET Trac] [Einstein Toolkit] #1526: CactusTest/TestArray outputs unitialized data for gf4d
Einstein Toolkit
trac-noreply at einsteintoolkit.org
Wed Jan 22 13:19:27 CST 2014
#1526: CactusTest/TestArray outputs unitialized data for gf4d
------------------------------------+---------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: closed
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Resolution: fixed | Keywords: CactusTest
------------------------------------+---------------------------------------
Changes (by rhaas):
* status: review => closed
* resolution: => fixed
Comment:
Replying to [comment:3 knarf]:
> The patch calls
> {{{
> CCTK_GrouplbndGI(ierr,cctkGH,4,lbnd_4d,groupindex3)
> }}}
> in a few places. Shouldn't it be groupindex4? Similarly 'varindex3'.
Fixed. Thank you for spotting this.
> Also, just minor, could line 316:
> {{{
> & (lbnd_4d(3)+k)*(lbnd_4d(4)+m)
> }}}
> be lined up such that these terms align with the ones on the previous
line?
Yes, in principle it should be. I have modifid the patch to mirror the
alignement of the 3d grid function loop which aligns the "(" with the "i"
of the line above. This was what I had initially intended but was off by
one space.
Applied as rev 68 of TestArray.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1526#comment:5>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
More information about the Trac
mailing list