[ET Trac] [Einstein Toolkit] #816: include SphericalHarmonicReconASCII from incoming in PITTNULLCode

Einstein Toolkit trac-noreply at einsteintoolkit.org
Wed Jan 22 20:41:48 CST 2014


#816: include SphericalHarmonicReconASCII from incoming in PITTNULLCode
------------------------------------+---------------------------------------
  Reporter:  rhaas                  |       Owner:     
      Type:  enhancement            |      Status:  new
  Priority:  optional               |   Milestone:     
 Component:  EinsteinToolkit thorn  |     Version:     
Resolution:                         |    Keywords:     
------------------------------------+---------------------------------------

Comment (by rhaas):

 I just have (for the first time) actually worked with the code. I believe
 that it will be best to spend an afternoon and clean up the code.

 TODO items:

 * make sure all externally visible functions with C linkage start with
 "SphericalHarmonicReconGeneric_"
 * consolidate the (global) variables in the SHR namespace into a single
 source file, vars.cc
 * remove commented out sections of code
 * use CCTK_INFO for informational output instead of cout
 * use CCTK_Error to abort rather than assert
 * clean up double vs CCTK_REAL issues
 * terminate cleanly when running out of data in mode files

-- 
Ticket URL: <https://trac.einsteintoolkit.org/ticket/816#comment:11>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit


More information about the Trac mailing list