Commits June 2018

commits@lists.einsteintoolkit.org

2 participants
7 discussions

commit/EinsteinEvolve: hklion: Fixed bug in calculation of conserved S vector in MHD Prim2Con
by Bitbucket 20 Jun '18

20 Jun '18

1 new commit in EinsteinEvolve: https://bitbucket.org/einsteintoolkit/einsteinevolve/commits/f73967f5e203/ Changeset: f73967f5e203 Branch: ET_2018_02 User: hklion Date: 2018-06-20 13:51:10+00:00 Summary: Fixed bug in calculation of conserved S vector in MHD Prim2Con Affected #: 1 file Repository URL: https://bitbucket.org/einsteintoolkit/einsteinevolve/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/EinsteinEvolve: 2 new changesets
by Bitbucket 20 Jun '18

20 Jun '18

2 new commits in EinsteinEvolve: https://bitbucket.org/einsteintoolkit/einsteinevolve/commits/c79140d90cda/ Changeset: c79140d90cda Branch: None User: hklion Date: 2018-05-18 22:51:03+00:00 Summary: Fixed bug in calculation of conserved S vector in MHD Prim2Con Affected #: 1 file https://bitbucket.org/einsteintoolkit/einsteinevolve/commits/2af01d5089b3/ Changeset: 2af01d5089b3 Branch: master User: hklion Date: 2018-06-20 13:47:21+00:00 Summary: Merged: Fixed bug in calculation of conserved S vector in MHD Prim2Con Fixed bug in calculation of conserved S vector in MHD Prim2Con Approved-by: Roland Haas <rhaas(a)illinois.edu> Affected #: 1 file Repository URL: https://bitbucket.org/einsteintoolkit/einsteinevolve/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/WVUThorns: zach_etienne: IllinoisGRMHD: No functional change -- fix comments in schedule.ccl to be consistent with reality
by Bitbucket 19 Jun '18

19 Jun '18

1 new commit in WVUThorns: https://bitbucket.org/zach_etienne/wvuthorns/commits/2a2cbe8bb565/ Changeset: 2a2cbe8bb565 Branch: master User: zach_etienne Date: 2018-06-19 12:15:34+00:00 Summary: IllinoisGRMHD: No functional change -- fix comments in schedule.ccl to be consistent with reality Affected #: 1 file Repository URL: https://bitbucket.org/zach_etienne/wvuthorns/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/WVUThorns: zach_etienne: IllinoisGRMHD, ID_converter_ILGRMHD: Fix the double-added T_munu at t=0; also fix a conservative-to-primitive scheduling typo
by Bitbucket 19 Jun '18

19 Jun '18

1 new commit in WVUThorns: https://bitbucket.org/zach_etienne/wvuthorns/commits/8b562af09a88/ Changeset: 8b562af09a88 Branch: master User: zach_etienne Date: 2018-06-19 12:13:20+00:00 Summary: IllinoisGRMHD,ID_converter_ILGRMHD: Fix the double-added T_munu at t=0; also fix a conservative-to-primitive scheduling typo Two bugs in IllinoisGRMHD were reported by Elias Most, who also suggested fixes. 1) The HydroBase eT[mu][nu] variables were being double-added at t=0 due to the fact that eT[mu][nu] were being set via eT[mu][nu] += TDNMUNU in IllinoisGRMHD's conservative-to-primitive solver. While this is a cute solution given that the solver is often called within the *Add*toTmunu scheduling bin (emphasis mine), it is inconsistent with how eT[mu][nu] is set within the outer_boundary routine (i.e., non-additively), and generally inconsistent with how IllinoisGRMHD interacts with other thorns. (IllinoisGRMHD should set eT[mu][nu], and if other thorns want to add, they are welcome to do so. Due to an additional call to IllinoisGRMHD's conservative-to-primitive solver in CCTK_POSTPOSTINITIAL, TDNMUNU was being added *twice* at t=0, resulting in bad data being added to the RHSs of Einstein's equations at t=0. The IllinoisGRMHD/test results were updated (difference at the 4th or 5th significant digit) due to this bug fix. 2) The outer boundary routine was scheduled "after conserv_to_prims", except no such function or scheduling alias exists anymore. The correct scheduling is "after IllinoisGRMHD_conserv_to_prims". The scheduler had already scheduled this correctly, so fixing this bug has no effect on results. Regardless, the typo was fixed. Affected #: 5 files Repository URL: https://bitbucket.org/zach_etienne/wvuthorns/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/WVUThorns: zach_etienne: IllinoisGRMHD, ID_converter_ILGRMHD: Fix the double-added T_munu at t=0; also fix a conservative-to-primitive scheduling typo
by Bitbucket 19 Jun '18

19 Jun '18

1 new commit in WVUThorns: https://bitbucket.org/zach_etienne/wvuthorns/commits/212ff43d0e89/ Changeset: 212ff43d0e89 Branch: ET_2018_02 User: zach_etienne Date: 2018-06-19 11:54:02+00:00 Summary: IllinoisGRMHD,ID_converter_ILGRMHD: Fix the double-added T_munu at t=0; also fix a conservative-to-primitive scheduling typo Two bugs in IllinoisGRMHD were reported by Elias Most, who also suggested fixes. 1) The HydroBase eT[mu][nu] variables were being double-added at t=0 due to the fact that eT[mu][nu] were being set via eT[mu][nu] += TDNMUNU in IllinoisGRMHD's conservative-to-primitive solver. While this is a cute solution given that the solver is often called within the *Add*toTmunu scheduling bin (emphasis mine), it is inconsistent with how eT[mu][nu] is set within the outer_boundary routine (i.e., non-additively), and generally inconsistent with how IllinoisGRMHD interacts with other thorns. (IllinoisGRMHD should set eT[mu][nu], and if other thorns want to add, they are welcome to do so. Due to an additional call to IllinoisGRMHD's conservative-to-primitive solver in CCTK_POSTPOSTINITIAL, TDNMUNU was being added *twice* at t=0, resulting in bad data being added to the RHSs of Einstein's equations at t=0. The IllinoisGRMHD/test results were updated (difference at the 4th or 5th significant digit) due to this bug fix. 2) The outer boundary routine was scheduled "after conserv_to_prims", except no such function or scheduling alias exists anymore. The correct scheduling is "after IllinoisGRMHD_conserv_to_prims". The scheduler had already scheduled this correctly, so fixing this bug has no effect on results. Regardless, the typo was fixed. Affected #: 4 files Repository URL: https://bitbucket.org/zach_etienne/wvuthorns/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

commit/EinsteinEvolve: rhaas80: GRHydro: add cctkGH to commented out debug code
by Bitbucket 17 Jun '18

17 Jun '18

1 new commit in EinsteinEvolve: https://bitbucket.org/einsteintoolkit/einsteinevolve/commits/1616646ef3db/ Changeset: 1616646ef3db Branch: master User: rhaas80 Date: 2018-06-17 17:52:43+00:00 Summary: GRHydro: add cctkGH to commented out debug code Affected #: 1 file Repository URL: https://bitbucket.org/einsteintoolkit/einsteinevolve/ -- This is a commit notification from bitbucket.org. You are receiving this because you have the service enabled, addressing the recipient of this email.

1 0

[ianhinder/Kranc] cbb101: New: GroupsPrint. For debugging.
by David M. Koppelman 12 Jun '18

12 Jun '18

Branch: refs/heads/dmk-chemora Home: https://github.com/ianhinder/Kranc Commit: cbb1015bd03a0f47e185f01ac8c40afaa174a7bd https://github.com/ianhinder/Kranc/commit/cbb1015bd03a0f47e185f01ac8c40afaa… Author: David M. Koppelman <koppel(a)ece.lsu.edu> Date: 2018-06-12 (Tue, 12 Jun 2018) Changed paths: M Tools/CodeGen/KrancGroups.m Log Message: ----------- New: GroupsPrint. For debugging. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Commits June 2018