User: rhaas Date: 2012/05/11 05:17 PM
Modified: /trunk/src/ GRHydro_PPM.F90
Log: GRHydro: correct reconstruction of velocities in ePPM
This is a bug fix to the ePPM scheme. The velocity components were reconstructed from the plus face values! This is clearly incorrect.
Patch by Christian Reisswig.
File Changes:
Directory: /trunk/src/ ======================
File [modified]: GRHydro_PPM.F90 Delta lines: +6 -6 =================================================================== --- trunk/src/GRHydro_PPM.F90 2012-05-05 02:43:22 UTC (rev 317) +++ trunk/src/GRHydro_PPM.F90 2012-05-11 22:17:18 UTC (rev 318) @@ -229,15 +229,15 @@ LIMIT(rho, rhoplus(i), enhanced_ppm_C2, rhoplus(i)) rhominus(i+1) = rhoplus(i)
- APPROX_AT_CELL_INTERFACE(velxplus, velxplus(i)) + APPROX_AT_CELL_INTERFACE(velx, velxplus(i)) LIMIT(velx, velxplus(i), enhanced_ppm_C2, velxplus(i)) velxminus(i+1) = velxplus(i)
- APPROX_AT_CELL_INTERFACE(velyplus, velyplus(i)) + APPROX_AT_CELL_INTERFACE(vely, velyplus(i)) LIMIT(vely, velyplus(i), enhanced_ppm_C2, velyplus(i)) velyminus(i+1) = velyplus(i)
- APPROX_AT_CELL_INTERFACE(velzplus, velzplus(i)) + APPROX_AT_CELL_INTERFACE(velz, velzplus(i)) LIMIT(velz, velzplus(i), enhanced_ppm_C2, velzplus(i)) velzminus(i+1) = velzplus(i) end do @@ -258,15 +258,15 @@ LIMIT(rho, rhoplus(i), enhanced_ppm_C2, rhoplus(i)) rhominus(i+1) = rhoplus(i)
- APPROX_AT_CELL_INTERFACE_STENCIL4(velxplus, velxplus(i)) + APPROX_AT_CELL_INTERFACE_STENCIL4(velx, velxplus(i)) LIMIT(velx, velxplus(i), enhanced_ppm_C2, velxplus(i)) velxminus(i+1) = velxplus(i)
- APPROX_AT_CELL_INTERFACE_STENCIL4(velyplus, velyplus(i)) + APPROX_AT_CELL_INTERFACE_STENCIL4(vely, velyplus(i)) LIMIT(vely, velyplus(i), enhanced_ppm_C2, velyplus(i)) velyminus(i+1) = velyplus(i)
- APPROX_AT_CELL_INTERFACE_STENCIL4(velzplus, velzplus(i)) + APPROX_AT_CELL_INTERFACE_STENCIL4(velz, velzplus(i)) LIMIT(velz, velzplus(i), enhanced_ppm_C2, velzplus(i)) velzminus(i+1) = velzplus(i) end do
commits@lists.einsteintoolkit.org